HamburgerMenu focus indicator for keyboard navigation fix #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsListView and OptionsListView
nmetulev
approved these changes
Jul 20, 2018
azchohfi
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1306
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When navigating the menu with the keyboard, the selected index / current page indicator follow the focus, but the page only changes when clicking the enter/space key.
What is the new behavior?
The selected index / current page indicator and the page only change after clicking the enter/space key.
PR Checklist
Please check if your PR fulfills the following requirements: