Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asserts hit in DEBUG builds for WinForms WebView #2344

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

rjmurillo
Copy link
Contributor

@rjmurillo rjmurillo commented Aug 1, 2018

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When using the debug builds of the WinForms WebView control, some circumstances may trigger an assert that causes delays while using the Visual Studio designer.

What is the new behavior?

Update conditions for which asserts are hit in DEBUG builds only

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

As a workaround, the compiler constant DEV_DEBUG can be removed to turn off the more aggressive asserts. CC @GraniteStateHacker

This can cause significant delays when using the designer with debug builds of the WinForms WebView
@azchohfi azchohfi merged commit a4a98da into CommunityToolkit:master Aug 2, 2018
@rjmurillo rjmurillo deleted the WebView/Designer_Delay branch August 3, 2018 22:34
@rjmurillo rjmurillo restored the WebView/Designer_Delay branch August 3, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants