Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more tests for State classes and CardFactory #498

Merged
merged 1 commit into from
Sep 27, 2018
Merged

add more tests for State classes and CardFactory #498

merged 1 commit into from
Sep 27, 2018

Conversation

stevengum
Copy link
Member

  • Add CardFactory.oauthCard() tests
  • Add coverage tests for the *State classes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1668

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 69.559%
Totals Coverage Status
Change from base Build 1663: 0.2%
Covered Lines: 2179
Relevant Lines: 3007
💛 - Coveralls

Stevenic
Stevenic approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit cda11bc into master Sep 27, 2018
@Stevenic Stevenic deleted the stgum/core branch September 27, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @Stevenic