Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tslint rules to all files #510

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Apply tslint rules to all files #510

merged 3 commits into from
Oct 3, 2018

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Oct 2, 2018

Some recent updates had slipped through without conforming to the linter guidelines. I've applied them to all the latest updates.

@coveralls
Copy link

coveralls commented Oct 2, 2018

Pull Request Test Coverage Report for Build 1726

  • 54 of 62 (87.1%) changed or added relevant lines in 18 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 70.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/componentDialog.ts 0 1 0.0%
libraries/botframework-connector/src/auth/jwtTokenValidation.ts 4 6 66.67%
libraries/botframework-connector/src/oAuthApiClient.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-connector/src/auth/microsoftAppCredentials.ts 1 64.63%
libraries/botframework-connector/src/oAuthApiClient.ts 1 1.13%
libraries/botframework-config/src/botConfigurationBase.ts 1 88.14%
Totals Coverage Status
Change from base Build 1724: 0.0%
Covered Lines: 2206
Relevant Lines: 3003

💛 - Coveralls

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit db9c461 into master Oct 3, 2018
@Stevenic Stevenic deleted the benbrown/tslint branch October 3, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants