Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm packages vulnerabilities in Tools #512

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

JuanAr
Copy link
Collaborator

@JuanAr JuanAr commented Oct 2, 2018

  • Removed tools/runtime containing a copy of an old unused version of 'ms-rest' and 'ms-rest-azure' (These folder contained several vulnerabilities)
  • Remove unused vulnerable 'grunt*' dependencies.
    • "grunt": "~0.4"
    • "grunt-contrib-connect": "^0.10.1"
    • "grunt-contrib-symlink": "^0.3.0"
    • "grunt-devserver": "~0.6"
    • "grunt-gh-pages": "1.1.0"
    • "grunt-jsdoc": "~0.6"

Note: We simply removed those vulnerable dependencies reported by GitHub. However, we should review this entire folder and check if some of these assets are no longer in use.

JuanAr added 2 commits October 2, 2018 18:31
- This folder contained a copy of an old version of 'ms-rest' and 'ms-rest-azure'
@coveralls
Copy link

coveralls commented Oct 2, 2018

Pull Request Test Coverage Report for Build 1755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.371%

Totals Coverage Status
Change from base Build 1750: 0.0%
Covered Lines: 2234
Relevant Lines: 3017

💛 - Coveralls

@benbrown benbrown merged commit fbf5af5 into master Oct 9, 2018
@JuanAr JuanAr deleted the southworks/npm-audit/tools branch October 9, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants