Bugfix BotFrameworkAdapter.createConversation #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #531. @Stevenic @benbrown @tomlm @stevengum do you think you could take a quick look at this? Seems pretty straightforward but looking forward to your feedback - cheers! |
mecampbellsoup
force-pushed
the
fix-bot-framework-adapter-create-conversation
branch
5 times, most recently
from
b9986af to
d49f184
Compare
Take `reference.user` and wrap in an Array literal to set `ConversationParameters.members`.
mecampbellsoup
force-pushed
the
fix-bot-framework-adapter-create-conversation
branch
from
9f5aadd to
52a9842
Compare
mecampbellsoup
deleted the
fix-bot-framework-adapter-create-conversation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API endpoint for creating conversations requires a
Conversationobject parameter, and as such the SDK function requires additional parameters includingmembersand potentiallytopicNameandactivityas well per:https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-connector-api-reference?view=azure-bot-service-4.0#create-conversation
https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-connector-api-reference?view=azure-bot-service-4.0#conversation-object