New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ConfirmPrompt and Prompt.appendChoices() bugs, add tests #537

Merged

stevengum merged 2 commits into master from stgum/confirmPrompt

Oct 15, 2018

Member

stevengum commented Oct 12, 2018 •

edited

Loading

Fixes same bugs as in microsoft/botbuilder-dotnet#1019 & microsoft/botbuilder-dotnet#1022


          fix ConfirmPrompt and Prompt.appendChoices() bugs, add tests

99aa9c4

stevengum requested a review from johnataylor

October 12, 2018 22:32

johnataylor approved these changes

View reviewed changes


          Merge branch 'master' into stgum/confirmPrompt

b3523e9

coveralls commented Oct 13, 2018 •

edited

Loading

Pull Request Test Coverage Report for Build 1820

11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 73.265%

Totals
Change from base Build 1818:	0.2%
Covered Lines:	2317
Relevant Lines:	3057

💛 - Coveralls

stevengum merged commit 3292b7c into master

stevengum deleted the stgum/confirmPrompt branch

October 15, 2018 17:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet