Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete deprecated Generator code #550

Merged
merged 1 commit into from
Oct 17, 2018
Merged

delete deprecated Generator code #550

merged 1 commit into from
Oct 17, 2018

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Oct 17, 2018 •
edited
Loading

Fixes #524

benbrown
benbrown approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@benbrown benbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the best type of change. bye bye files!

@benbrown benbrown changed the title delete Generator code delete deprecated Generator code Oct 17, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1860

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 73.202%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 1845: -0.06%
Covered Lines: 2315
Relevant Lines: 3057
💛 - Coveralls

@stevengum stevengum merged commit 4583878 into master Oct 17, 2018
@stevengum stevengum deleted the stgum/deleteGenerator branch October 17, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbrown benbrown benbrown approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @benbrown