Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and Updates to the CosmosDB Storage Provider #556

Merged
merged 7 commits into from
Oct 22, 2018
Merged

Fixes and Updates to the CosmosDB Storage Provider #556

merged 7 commits into from
Oct 22, 2018

Conversation

enzocano
Copy link
Contributor

  • Extracted Key Escaping into a dedicated class (with tests).
  • Added numerous CTor exception tests.
  • Fixed race condition around Initialization

Based on microsoft/botbuilder-dotnet#1014

@enzocano enzocano requested a review from cleemullins October 19, 2018 19:39
@coveralls
Copy link

coveralls commented Oct 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1910

  • 27 of 43 (62.79%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 73.528%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure/src/cosmosDbKeyEscape.ts 13 14 92.86%
libraries/botbuilder-azure/src/cosmosDbStorage.ts 13 28 46.43%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure/src/cosmosDbStorage.ts 1 22.08%
Totals Coverage Status
Change from base Build 1909: 0.4%
Covered Lines: 2319
Relevant Lines: 3054
💛 - Coveralls

Stevenic
Stevenic approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins cleemullins merged commit 5550ab1 into microsoft:master Oct 22, 2018
@enzocano enzocano deleted the southworks/cosmosdb-fixes branch October 23, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum left review comments

@johnataylor johnataylor johnataylor approved these changes

@cleemullins cleemullins cleemullins approved these changes

@Stevenic Stevenic Stevenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enzocano @coveralls @Stevenic @cleemullins @johnataylor @stevengum