Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct improper use of await in function declarations #617

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Correct improper use of await in function declarations #617

merged 2 commits into from
Nov 8, 2018

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Nov 8, 2018

Fixes #611

We had incorrectly used await in the place of async in some function declarations in the comments, which then get published in our docs.

@benbrown benbrown merged commit c472cb4 into master Nov 8, 2018
@benbrown benbrown deleted the benbrown/awaitasyncswap branch November 8, 2018 21:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2104

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 82.13%
Totals Coverage Status
Change from base Build 2073: -0.02%
Covered Lines: 2633
Relevant Lines: 3088
💛 - Coveralls

@yochay yochay mentioned this pull request Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbrown @coveralls @stevengum