Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft/omsour/composite_roles #622

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

omarsourour
Copy link

Description

Ensured that normalized entity names are surfaced from inside composite entities. This ensures that objects like roles can be captured from inside composite entities.

Specific Changes

  • Applied fix to LuisRecognizer to ensure that normalized entities are surfaced from composites.
  • Added unit tests for this case.
  • Updated oracle test files with new application scores.
  • Renamed test files that have matches in the dotnet SDK for consistency.

@omarsourour omarsourour changed the title Microsoft/omsour/composite roles Microsoft/omsour/composite_roles Nov 9, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2122

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 82.088%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 2118: -0.04%
Covered Lines: 2631
Relevant Lines: 3088

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants