Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix confirm prompt when invalid locale used with number selection #654

Merged
merged 3 commits into from
Nov 21, 2018

Conversation

johnataylor
Copy link
Member

@johnataylor johnataylor commented Nov 21, 2018

Fixes #648

Description

Confirm prompt had exception when invalid locale used with number selection.

(I'm also aligning the implementation slightly with the c# - calling the variable culture.)

Note the defaults tables should be merged - however they are public - they shouldn't be public. We can treat this as a separate issue.

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 2205

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 82.087%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 2201: -0.07%
Covered Lines: 2630
Relevant Lines: 3085

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor linting, and question about the deteremineCulture() method.

libraries/botbuilder-dialogs/src/prompts/confirmPrompt.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs/src/prompts/confirmPrompt.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs/src/prompts/confirmPrompt.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants