ActivityPrompt wasn't using retryPrompt if specified. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
approved these changes
Dec 3, 2018
Pull Request Test Coverage Report for Build 2363
💛 - Coveralls |
Co-Authored-By: Stevenic <stevenic@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
Description
ActivityPrompt wasn't using the retryPrompt option if it was passed in as part of the prompt options. This made it inconsistent with the other prompts.
Specific Changes
ActivityPrompt now works more like the other prompts and will automatically re-prompt the user if the received activity is a "message" and was un-handled.
Testing
Updated unit tests and added an additional test.