Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BotState.delete() method and tests #679

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented Dec 4, 2018

Fixes microsoft/botframework-sdk#5175

Description

Adds a new BotState.delete() method.

Specific Changes

Added method and unit tests.

Testing

Included

@coveralls
Copy link

coveralls commented Dec 4, 2018

Pull Request Test Coverage Report for Build 2366

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 82.223%

Totals Coverage Status
Change from base Build 2364: 0.06%
Covered Lines: 2635
Relevant Lines: 3085

💛 - Coveralls

Copy link
Contributor

@benbrown benbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth updating the comment on the clear() method and/or the delete() method to specify the difference?

@Stevenic
Copy link
Contributor Author

Stevenic commented Dec 4, 2018

I put the differences in the remarks of each method but if you feel like you have better descriptions feel free to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants