Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppInsights package into build publish step #688

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

cleemullins
Copy link
Contributor

@cleemullins cleemullins commented Dec 5, 2018

Add the new -appinsights package into the build process so the NPM publishes to MyGet.

Fixes #674

@cleemullins cleemullins self-assigned this Dec 5, 2018
@cleemullins cleemullins added P0 Must Fix. Release-blocker Approved 4.2 December 15, 2018 Release labels Dec 6, 2018
@johnataylor johnataylor merged commit e438d79 into master Dec 6, 2018
@johnataylor johnataylor deleted the cleemullins-patch-1 branch December 6, 2018 00:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2400

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 82.198%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 2395: -0.06%
Covered Lines: 2703
Relevant Lines: 3165

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2 December 15, 2018 Release P0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants