Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more language around daily builds #701

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Add more language around daily builds #701

merged 3 commits into from
Dec 19, 2018

Conversation

sgellock
Copy link
Member

the README makes it seem like you should use daily builds. this PR adds clarity as to when you would consider using daily bits.

the README makes it seem like you should use daily builds. this PR adds clarity as to when you would consider using daily bits.
@coveralls
Copy link

coveralls commented Dec 16, 2018

Pull Request Test Coverage Report for Build 2466

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 82.198%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #1650: -0.06%
Covered Lines: 2703
Relevant Lines: 3165

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving PR, just one minor typo to fix!

@@ -17,7 +17,8 @@ To add the latest version of this package to your bot:
npm install --save botbuilder-dialogs
```

#### Use the Daily Build
#### How to Use Daily Builds
If you want to play with the very latest versions of botbuilder, you can opt in to working with the daily builds. This is not meant to be used in a production environment and is for advanced development. Quality will vary and you should only use daily builds for exploritory purposes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"exploritory" should be "exploratory" but otherwise LGTM

@sgellock sgellock merged commit 4589b5b into master Dec 19, 2018
@sgellock sgellock deleted the sgellock-patch-1 branch December 19, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants