-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for channelData field in conversation references #712
Conversation
…Conversation (required for MS Teams)
Pull Request Test Coverage Report for Build #1965
💛 - Coveralls |
@benbrown, is there anything we need to pickup on the C# side for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for my comment about botbuilder-schema, it looks fine to me! Once that bit is squared away feel free to merge.
* @member {any} [channelData] Channel specific payload for re-creating the | ||
* conversation | ||
*/ | ||
channelData?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh-oh, this looks like it's hand-crafted! We need to chat with Dan/Jeff/someone from the other side of the house to get this change into the Swagger definitions.
Or did you regenerate the Swagger files and this code was originally missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot! You are right, I added this by hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this information can go into the conversationReference.channel
field instead. However, that would still require a change to the schema. I'll collect some feedback and regroup.
This PR is tied to: microsoft/botbuilder-dotnet#1362 Both should be merged at the same time. |
OK! The service code has changed to include this new field in the schema. We need to regenerate! |
I have manually made the very small schema changes. These should match any future update from swagger. |
Just waiting on one final tweak to the dot-net version, then we can merge both! |
Description
The conversationReference type is missing fields necessary to use
createConversation
with MS Teams. This PR adds those fields and amends the functions so that they will work with Teams.Specific Changes
Adds the channelData field to the conversation reference. Information in channelData may be required for operations that use references -- for example, createConversation.
Amends the adapter's createConversation method to pass through the tenant id, which is necessary for using this method with MS Teams.
Testing