Updated master build status badge #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build status badge for master has now been updated with the new Azure Devops build badge.
Pull Request Test Coverage Report for Build 2550
💛 - Coveralls |
cleemullins
requested changes
Jan 10, 2019
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # Bot Builder SDK v4 | |||
| | Branch | Description | Build Status | Coverage Status | | |||
| |----|---------------|--------------|-----------------| | |||
| |Master | 4.2.* Preview Builds |[](https://travis-ci.org/Microsoft/botbuilder-js) |[](https://coveralls.io/github/Microsoft/botbuilder-js?branch=master) | |||
| |Master | 4.2.* Preview Builds |[](https://fuselabs.visualstudio.com/SDK_v4/_build/latest?definitionId=374)|[](https://coveralls.io/github/Microsoft/botbuilder-js?branch=master) | |||
There was a problem hiding this comment.
I don't know if this is right. I think devops also needs the "branch=master" URL paramter.
W/o that, any time the build fails on any branch, the master branch would be marked as failed.
There was a problem hiding this comment.
"?branchName=master" is the AzureDevops paramter that's needed.
You can see in the .Net version of this repo, where I did this for both Azure Devops and Coveralls:
Master | 4.3.* Preview Builds | |
There was a problem hiding this comment.
Good save - I've added a commit to correct this, thanks!
As pointed out by Chris, I've corrected the badge link to be branch-specific.
cleemullins
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build status badge for master has now been updated with the new Azure Devops build badge.