Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @types/node to v10.12.18 #724

Merged
merged 3 commits into from
Jan 18, 2019

Conversation

gasper-az
Copy link
Contributor

@gasper-az gasper-az commented Jan 15, 2019

Description

  • Update NodeJS version for supporting RegExp related features natively, like lookBehind assertions and named capture groups. These changes are supported since the v.10.3.0 version, but we update the project's version to the v10.15.0 (v.10.12.18 in typescript) as it is the current LTS.

image

A PR for supporting these changes was also created in Recognizers-text project (PR#1069)

  • Update the tsconfig.json files to target ESNext as Node JS v.10 has good native support for most ESNext language built-ins, which will reduce file size and improve the debugging experience and performance.

Specific Changes

  • Update libraries/botbuilder-ai/package.json @types/node to ^10.12.18.
  • Update libraries/botbuilder-azure/package.json @types/node to ^10.12.18.
  • Update libraries/botbuilder-dialogs/package.json @types/node to ^10.12.18.
  • Update libraries/botbuilder/package.json @types/node to ^10.12.18.
  • Update libraries/botbuilder-connector/package.json @types/node to ^10.12.18.
  • Update libraries/botbuilder-schema/package.json @types/node to ^10.12.18.
  • Update transcript/package.json @types/node to ^10.12.18.
  • Reload package-lock.json.
  • Update libraries/botbuilder/tsconfig.json target to ESNext
  • Update libraries/botbuilder-ai/tsconfig.json target to ESNext
  • Update libraries/botbuilder-applicationinsights/tsconfig.json target to ESNext
  • Update libraries/botbuilder-azure/tsconfig.json target to ESNext
  • Update libraries/botbuilder-core/tsconfig.json target to ESNext
  • Update libraries/botbuilder-dialogs/tsconfig.json target to ESNext
  • Update libraries/botframework-config/tsconfig.json target to ESNext
  • Update libraries/botframework-connector/tsconfig.json target to ESNext
  • Update libraries/botframework-schema/tsconfig.json target to ESNext

@gasper-az gasper-az changed the title Fix/update nodejs v10.12.18 Update @types/node to v10.12.18 Jan 15, 2019
@coveralls
Copy link

coveralls commented Jan 15, 2019

Pull Request Test Coverage Report for Build 2587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 82.205%

Totals Coverage Status
Change from base Build #1799: -0.007%
Covered Lines: 2703
Relevant Lines: 3163

💛 - Coveralls

@cleemullins cleemullins merged commit 3314b83 into microsoft:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants