Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made linting fixes to QnAMaker #731

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Made linting fixes to QnAMaker #731

merged 2 commits into from
Jan 28, 2019

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented Jan 28, 2019

Description

Turned on tslint and fixed linting errors from PR #704

Specific Changes

  • got rid of trailing whitepsaces
  • added types on variables missing typing
  • moved deprecated methods to appear before private methods, as they are of public or protected accessibility

@Zerryth Zerryth requested a review from stevengum January 28, 2019 23:37
@coveralls
Copy link

coveralls commented Jan 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2613

  • 37 of 37 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 82.45%
Totals Coverage Status
Change from base Build #1831: -0.02%
Covered Lines: 2732
Relevant Lines: 3188
💛 - Coveralls

stevengum
stevengum approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 39d7cf9 into master Jan 28, 2019
@stevengum stevengum deleted the Zerryth/QnALinted branch January 28, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zerryth @coveralls @stevengum