Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Cortana from trying to use suggested actions in prompts #732

Merged
merged 4 commits into from
Jan 30, 2019

Conversation

v-kydela
Copy link
Contributor

Fixes microsoft/botbuilder-dotnet#1173

Description

I have modified choiceFactory.ts by removing hasMessageFeed and supportsCardActions from the if condition so that now a channel must support suggested actions in order for the SDK to automatically select them as the list style. I have also deleted those local variables for cleanliness since they aren't being used anywhere else.

@v-kydela v-kydela requested a review from benbrown January 29, 2019 19:53
@coveralls
Copy link

coveralls commented Jan 29, 2019

Pull Request Test Coverage Report for Build 2638

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 82.418%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs/src/choices/channel.ts 2 68.18%
Totals Coverage Status
Change from base Build #1864: -0.1%
Covered Lines: 2738
Relevant Lines: 3194

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to cover the scenario mentioned in microsoft/botbuilder-dotnet#1173

@v-kydela
Copy link
Contributor Author

@stevengum - I just pushed another commit

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 937be3f into master Jan 30, 2019
@Stevenic Stevenic deleted the v-kydela/cortana-suggested-actions branch January 30, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants