Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema issues #751

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix schema issues #751

merged 1 commit into from
Feb 5, 2019

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Feb 2, 2019 •
edited
Loading

Description

  • Latest round of schema generation added ms-rest dependencies to botbuilder-schema
  • We also are missing the activity signatures as interfaces (which do exist in C#)

Specific Changes

  • moved classes that should be in connector from schema -> connector
  • added activityInterfaces.ts file which is 100% in sync with activity spec definitions.

Testing

No new functionality, just refactoring

Fix schema issues
c6e60c8 
* ms-rest client depdenencies shouldn't be in schema project => moved assets to connector
* Added Activity interface signatures to schema to bring in compliance with C#
@coveralls
Copy link

coveralls commented Feb 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2666

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 82.434%
Totals Coverage Status
Change from base Build #1891: -0.007%
Covered Lines: 2737
Relevant Lines: 3193
💛 - Coveralls

@cleemullins cleemullins merged commit d1d32b5 into master Feb 5, 2019
@cleemullins cleemullins deleted the tomlm/FixSchema branch February 5, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomlm @coveralls @cleemullins