Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to test OAuthPrompt and mock OAuth APIs #759

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

Jeffders
Copy link
Member

@Jeffders Jeffders commented Feb 6, 2019

Description

Ability to mock the OAuth APIs on a BotAdapter
Implementation of mock in TestAdapter
Ensure OAuthPrompt uses the new interface
Sample unit tests for how to test OAuth APIs and the OAuthPrompt

Testing

Yes, tests on TestAdapter and OAuthPrompt

@Jeffders Jeffders requested review from cleemullins and tomlm February 6, 2019 22:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build #1934

  • 42 of 47 (89.36%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 84.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts 2 3 66.67%
libraries/botbuilder-core/src/testAdapter.ts 38 40 95.0%
libraries/botbuilder/src/botFrameworkAdapter.ts 2 4 50.0%
Totals Coverage Status
Change from base Build #1932: 1.8%
Covered Lines: 2824
Relevant Lines: 3232

💛 - Coveralls

@Jeffders Jeffders merged commit c9c2da6 into master Feb 7, 2019
@cleemullins cleemullins deleted the jeffders/oauthtestability branch March 5, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants