Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LUIS to new (Azure) nodejs SDK #766

Merged
merged 6 commits into from
Feb 19, 2019
Merged

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Feb 9, 2019

In conjunction with microsoft/botbuilder-dotnet#1367.

  • Update to latest Azure LUIS SDK.
  • Azure Autorest has updated their version of Autorest which uses Axios
  • Nock test updated to reflect

@coveralls
Copy link

coveralls commented Feb 9, 2019

Pull Request Test Coverage Report for Build #1996

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.5%

Totals Coverage Status
Change from base Build #1992: 0.0%
Covered Lines: 3006
Relevant Lines: 3306

💛 - Coveralls

Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick between async-file or fs-extra in the project but not both.

"botbuilder": "~4.1.6",
"build": "^0.1.4",
"fs-extra": "^7.0.1",
Copy link
Contributor

@justinwilaby justinwilaby Feb 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that including fs-extra will introduce 2 dependencies that do the same thing into our production code. async-file is used currently and it makes sense to pick one and standardize on it. fs-extra is my first choice but async-file is fine too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justin for the review! I'm not sure where you're seeing the dependency on async-file. fs-extra appears to be being used by the bot framework, so we should probably keep that.
The new set of bits is adoption of new ms-rest stuff which doesn't appear to have a async-file dependency (?).

@justinwilaby
Copy link
Contributor

It looks like the unit tests were updated but coveralls is reporting the entire error block missing coverage. Any ideas what happened here?

@daveta daveta requested a review from stevengum February 15, 2019 14:26
@daveta
Copy link
Contributor Author

daveta commented Feb 15, 2019

It looks like the unit tests were updated but coveralls is reporting the entire error block missing coverage. Any ideas what happened here?

Nice catch, I checked in fixed tests!

@stevengum stevengum self-assigned this Feb 15, 2019
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I was also the last person to touch this PR 😄 @justinwilaby, @daveta or @cleemullins can you take a look?

@cleemullins cleemullins dismissed justinwilaby’s stale review February 19, 2019 18:28

All feedback addressed, looking to merge.

@cleemullins cleemullins merged commit 5860634 into master Feb 19, 2019
@cleemullins cleemullins deleted the daveta-update-luis branch February 19, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants