Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Package formatting and layout #782

Merged
merged 3 commits into from
Feb 16, 2019
Merged

Updates to Package formatting and layout #782

merged 3 commits into from
Feb 16, 2019

Conversation

cleemullins
Copy link
Contributor

@cleemullins cleemullins commented Feb 15, 2019 •
edited
Loading

Fixes #777, #778

Description

Moved to an Include model to only pull in specific files. Initial cut is "/src/" and "/lib" added as a whitelist in the package.json.

@cleemullins cleemullins added the blocked Current progress is blocked on something else. label Feb 15, 2019
@cleemullins cleemullins self-assigned this Feb 15, 2019
@cleemullins cleemullins requested a review from benbrown February 15, 2019 21:52
@cleemullins cleemullins requested a review from Stevenic February 16, 2019 00:19
@cleemullins
Copy link
Contributor Author

Tested by Jessica and has passed her checks.

@coveralls
Copy link

coveralls commented Feb 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build #1987

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.5%
Totals Coverage Status
Change from base Build #1985: 0.06%
Covered Lines: 3006
Relevant Lines: 3306
💛 - Coveralls

Stevenic
Stevenic approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins cleemullins removed the blocked Current progress is blocked on something else. label Feb 16, 2019
@cleemullins cleemullins merged commit 791d917 into master Feb 16, 2019
@cleemullins cleemullins deleted the CLM/UpdatePackageFiles branch February 16, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@Stevenic Stevenic Stevenic approved these changes

@benbrown benbrown Awaiting requested review from benbrown

Assignees

@cleemullins cleemullins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cleemullins @coveralls @Stevenic @justinwilaby