Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved @types/documentdb to dependencies in package.json #821

Merged
merged 3 commits into from
Mar 27, 2019
Merged

moved @types/documentdb to dependencies in package.json #821

merged 3 commits into from
Mar 27, 2019

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented Mar 15, 2019

Fixes #804

Description

  • moved @types/documentdb from devDependencies to dependencies
  • wanted to note, that I actually was not able to repro the same error that ctstone (person who opened the issue) had gotten when testing with my own TS bot
    • however after speaking with Steven Gum on the team, decided to move forward in placing @types/documentdb into dependencies as he has in the past experienced a similar issue

@Zerryth Zerryth requested review from ctstone and stevengum March 15, 2019 21:18
@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build #2128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.618%
Totals Coverage Status
Change from base Build #2120: 0.0%
Covered Lines: 3192
Relevant Lines: 3499
💛 - Coveralls

ctstone
ctstone approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@ctstone ctstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. FYI you can repro the issue using this repo: https://github.com/ctstone/botbuilder-azure-repro-804

The issue only manifests if you import one of the documentdb (cosmosdb) types.

@benbrown benbrown merged commit a8128ba into master Mar 27, 2019
@benbrown benbrown deleted the Zerryth/DocumentDbDependency branch March 27, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctstone ctstone ctstone approved these changes

@benbrown benbrown benbrown approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zerryth @coveralls @benbrown @ctstone