Add getTokenStatus method #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #2183
💛 - Coveralls |
benbrown
suggested changes
Mar 27, 2019
| throw new Error(`BotFrameworkAdapter.getTokenStatus(): missing from or from.id`); | ||
| } | ||
| this.checkEmulatingOAuthCards(context); | ||
| ! userId? userId = context.activity.from.id : userId; |
There was a problem hiding this comment.
Can you use a more traditional if on this, the !userId? is a confusing bit of syntax for humans.
There was a problem hiding this comment.
Sure! Syntax updated 😄
benbrown
approved these changes
Mar 28, 2019
cleemullins
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Description
As requested in the mentioned issue, the method
getTokenStatuswas added to theBotFrameworkAdapterclass, using the logic that already existed in theuserTokenclass.Specific Changes
Testing