Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade LUIS to new SDK - this time with feeling #844

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Upgrade LUIS to new SDK - this time with feeling #844

merged 2 commits into from
Apr 2, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Apr 2, 2019

Update the LUIS SDK to upgrade to new Typescript-generated-autorest thing.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2145

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 87.562%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #2129: -0.06%
Covered Lines: 3190
Relevant Lines: 3499
💛 - Coveralls

stevengum
stevengum approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@Zerryth can you clone these changes and test it against a live LUIS app? Thanks!

Edit: If it works, merge the PR in 😄

@Zerryth
Copy link
Contributor

Zerryth commented Apr 2, 2019

Sure, will test and merge right after stand-up

@Zerryth
Copy link
Contributor

Zerryth commented Apr 2, 2019

green light go

fired up sample 12 in node and ran with Dave's changes without issue :)

@Zerryth Zerryth merged commit b0c245d into master Apr 2, 2019
@Zerryth Zerryth deleted the daveta-upgrade-luissdk branch April 2, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Zerryth Zerryth Awaiting requested review from Zerryth

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees

@Zerryth Zerryth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daveta @coveralls @Zerryth @stevengum