-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle textless messages differently, bringing Node into parity with .NET #856
Conversation
Pull Request Test Coverage Report for Build #2230
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but could you:
- Do the linting changes, and only the linting changes, in a PR.
- Once that's merged in, make the bug fix.
Looking through this PR I can't tell what's new and what's just a linting change, as the changeset is complex.
@cleemullins - All right, I went ahead and did the linting in its own PR and requested you as a reviewer: #867 I must have idly auto-formatted the document without realizing how much actually got changed |
@v-kydela When I look at the Diff of this PR, I still see all the linting changes. I did merge in the separate PR with those changes earlier this evening, so I'm surprised to see them still in this PR. Can you take a look? |
@cleemullins - It looks to me like your merge successfully removed the linting changes from this PR: Can you look again? Maybe clear your cache or something? If you need me to change this PR then I could try a rebase but that could get messy. Then of course the last resort would be to discard this PR and just create a new one. |
Fixes microsoft/botbuilder-dotnet#1349
Description
While there wasn't necessarily a bug in this repo, there was potential for LuisRecognizer to make a needless call to a LUIS endpoint when an utterance was empty. This PR gets the behavior of LuisRecognizer to match a recent V4 .NET PR which in turn is based off of V3 .NET. Now the
recognize
function will check if an utterance is empty and then create a fake result instead of getting a result from the endpoint in that case.Specific Changes
LuisRecognizer.recognize
now creates aRecognizerResult
with a blank intent if the activity's text is null or whitespaceRecognizerResult
instead of just thetopIntent
function becausetopIntent
converts the empty intent to NoneTesting
The EmptyText test has been modified to fit the new behavior.