Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add accordion web component #3067

Merged
merged 14 commits into from
May 29, 2020
Merged

feat: add accordion web component #3067

merged 14 commits into from
May 29, 2020

Conversation

eljefe223
Copy link
Contributor

Description

Adds fast-accordion as new web component

image

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@eljefe223 eljefe223 requested a review from janechu as a code owner May 6, 2020 18:47
@eljefe223 eljefe223 self-assigned this May 6, 2020
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch from 9c37725 to c5074c5 Compare May 6, 2020 21:04
chrisdholt
chrisdholt requested changes May 6, 2020
View reviewed changes
packages/web-components/fast-components/src/accordion/accordion-item/accordion-item.styles.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion-item/accordion-item.template.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion-item/accordion-item.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion.styles.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion-item/accordion-item.styles.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion-item/accordion-item.styles.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion.ts Outdated Show resolved Hide resolved
packages/web-components/fast-components/src/accordion/accordion.ts Outdated Show resolved Hide resolved
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch 2 times, most recently from d16db23 to 90e6aa0 Compare May 7, 2020 00:37
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch 2 times, most recently from 5a2cc98 to 13b29d2 Compare May 7, 2020 18:28
nicholasrice
nicholasrice approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but note the comment above ^

@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch 2 times, most recently from e55962e to e2a103e Compare May 8, 2020 20:23
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch from e2a103e to c1005c6 Compare May 28, 2020 16:18
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch from e033465 to da996f3 Compare May 28, 2020 16:46
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch from da996f3 to f179071 Compare May 28, 2020 18:19
@eljefe223 eljefe223 force-pushed the users/jes/accordion-component branch from f179071 to 1815989 Compare May 29, 2020 18:40
@eljefe223 eljefe223 merged commit f551378 into master May 29, 2020
@eljefe223 eljefe223 deleted the users/jes/accordion-component branch May 29, 2020 19:19
@chrisdholt chrisdholt mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scomea scomea scomea left review comments

@radium-v radium-v radium-v left review comments

@chrisdholt chrisdholt chrisdholt approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@janechu janechu Awaiting requested review from janechu janechu is a code owner

@awentzel awentzel Awaiting requested review from awentzel awentzel is a code owner

@Falkicon Falkicon Awaiting requested review from Falkicon Falkicon is a code owner

Assignees

@eljefe223 eljefe223

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eljefe223 @EisenbergEffect @radium-v @nicholasrice @scomea @chrisdholt