Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus visuals and style clean up #3145

Merged
merged 3 commits into from
May 15, 2020
Merged

fix: focus visuals and style clean up #3145

merged 3 commits into from
May 15, 2020

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented May 15, 2020

Description

  1. Cleans up several styling issues
  2. Focus visuals incorrect on some controls.
  3. Focus visuals not visible on some controls.
  4. Disabled controls still had hover and active states.
  5. Alignment of padding across text input controls
  6. Maps type ramp to design system in MSFT

Example Before:
image
image

Example After:
image
image
image

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Collaborator

@bheston bheston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That focus visual doesn't meet contrast requirements. For a dark fill like this there needs to be contrasting space between. Check the latest update to the msft styles that set focus as an external double border for checkbox, radio, and toggle.

@chrisdholt
Copy link
Member

chrisdholt commented May 15, 2020

That focus visual doesn't meet contrast requirements. For a dark fill like this there needs to be contrasting space between. Check the latest update to the msft styles that set focus as an external double border for checkbox, radio, and toggle.

@bheston can we take that as a fast-follow? It's going to require updating the recipes which I'd like to hold in a separate PR if we can.

EDIT: Additionally, I assume these are missing from the MSFT web components? The recipes are likely good there, but if you've changed the react components those likely aren't reflected in the current package.

@eljefe223
Copy link
Contributor Author

That focus visual doesn't meet contrast requirements. For a dark fill like this there needs to be contrasting space between. Check the latest update to the msft styles that set focus as an external double border for checkbox, radio, and toggle.

We should be good now.

@eljefe223 eljefe223 merged commit 8a77b2a into master May 15, 2020
@eljefe223 eljefe223 deleted the users/jes/clean-up branch May 15, 2020 18:57
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
chrisdholt pushed a commit that referenced this pull request May 18, 2020
* fix: focus visuals and style clean up

* More clean up

* Updated Focus visuals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants