-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: focus visuals and style clean up #3145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That focus visual doesn't meet contrast requirements. For a dark fill like this there needs to be contrasting space between. Check the latest update to the msft styles that set focus as an external double border for checkbox, radio, and toggle.
@bheston can we take that as a fast-follow? It's going to require updating the recipes which I'd like to hold in a separate PR if we can. EDIT: Additionally, I assume these are missing from the MSFT web components? The recipes are likely good there, but if you've changed the react components those likely aren't reflected in the current package. |
18df279
to
8d3d693
Compare
We should be good now. |
8d3d693
to
99b83b3
Compare
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
* fix: focus visuals and style clean up * More clean up * Updated Focus visuals
Description
Example Before:
Example After:
Issue type checklist
Is this a breaking change?
Process & policy checklist