fix: remove fast-components dependency in fast-components-msft #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
approved these changes
May 17, 2020
EisenbergEffect
approved these changes
May 17, 2020
chrisdholt
force-pushed
the
users/chhol/remove-fast-components-dep-from-msft
branch
from
e744d9c
to
12f3c3e
Compare
nicholasrice
approved these changes
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with dependencies.
fast-componentswas enumerated as a dependency offast-components-msftwhich is incorrect - the correct dependency should befast-foundation.Issue type checklist
Is this a breaking change?
Process & policy checklist