Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: outline on flipper #3204

Merged
merged 1 commit into from
May 29, 2020
Merged

fix: outline on flipper #3204

merged 1 commit into from
May 29, 2020

Conversation

eljefe223
Copy link
Contributor

Description

Outline was showing on focus on fast-flipper and hover and active states did not match.
Screen Shot 2020-05-29 at 1 08 07 PM

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@eljefe223 eljefe223 requested a review from janechu as a code owner May 29, 2020 20:30
@eljefe223 eljefe223 self-assigned this May 29, 2020
@eljefe223 eljefe223 merged commit a703703 into master May 29, 2020
@eljefe223 eljefe223 deleted the users/jes/flipper-focus branch May 29, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt chrisdholt is a code owner

@janechu janechu Awaiting requested review from janechu janechu is a code owner

Assignees

@eljefe223 eljefe223

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eljefe223 @EisenbergEffect @nicholasrice