Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change diff editor to a custom theme based on high contrast #387

Closed
alexdima opened this issue Mar 1, 2017 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Mar 1, 2017

	monaco.editor.defineTheme('custom-hc-theme-1', {
		base: 'hc-black',
		inherit: true,
		rules: []
	});

	diffEditor.updateOptions({
		theme: 'custom-hc-theme-1'
	});

Observe:

  • the two editors don't get the hc-black class name. they get:
    • monaco-editor custom-hc-theme-1 original-in-monaco-diff-editor and
    • monaco-editor custom-hc-theme-1 modified-in-monaco-diff-editor
  • the tokens don't switch to the high contrast tokens.
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Mar 1, 2017
@alexdima alexdima added this to the v0.8.x milestone Mar 1, 2017
@alexdima alexdima self-assigned this Mar 1, 2017
alexdima added a commit to microsoft/vscode that referenced this issue Mar 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants
@alexdima and others