Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

[clojure] Improve the regular expressions for various symbols #56

Merged
merged 6 commits into from
Jan 10, 2019
Merged

[clojure] Improve the regular expressions for various symbols #56

merged 6 commits into from
Jan 10, 2019

Conversation

finalfantasia
Copy link
Contributor

This PR:

  • Adds ".cljs" and ".cljc" to source file name extension list
  • Adds a word boundary to ensure exact matches for (comment ...) forms
  • Improves the regular expressions for various symbols
  • Removes a file name extension that's uncommon

alexdima
alexdima suggested changes Dec 7, 2018
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a couple funny looking regular expressions. Are you certain they do what you intend them to do?

src/clojure/clojure.ts Outdated Show resolved Hide resolved
Abdussalam Abdurrahman and others added 2 commits December 7, 2018 12:30
[clojure] Fix tokenization of escapes in strings
3f16600 
The notation for escapes in strings follows that of the host platforms
which is different from the notation for character literals in Clojure
(e.g., "\n" vs `\newline`).
@finalfantasia
Add ".edn" to the list of file name extensions
6b67516
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit f959584 into microsoft:master Jan 10, 2019
@alexdima alexdima added this to the February 2019 milestone Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@finalfantasia @alexdima