Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Clear the file fields of relatedInformation too. (WIP) #21

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

mattmccutchen
Copy link
Contributor

Should fix microsoft/TypeScript#26068.

WIP:

  • Needs to be tested, but I don't know how.
  • The TypeScript typings should probably be updated instead of casting to any, but I don't know how.

@mhegazy
Copy link

mhegazy commented Aug 2, 2018

//cc @kieferrm

@kieferrm kieferrm requested a review from jrieken August 2, 2018 22:39
@alexdima
Copy link
Member

alexdima commented Aug 8, 2018

👍 Thank you!

@alexdima alexdima merged commit 201fa54 into microsoft:master Aug 8, 2018
@alexdima alexdima added this to the July 2018 milestone Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground: Diagnostic with related information causes "Uncaught Error: Converting circular structure to JSON"
3 participants