Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigDecimal in TVP can incorrectly cause SQLServerException related to invalid precision or scale #86

Closed
jschulist opened this issue Dec 21, 2016 · 2 comments
Closed

BigDecimal in TVP can incorrectly cause SQLServerException related to invalid precision or scale #86

jschulist opened this issue Dec 21, 2016 · 2 comments
Assignees
@Suraiya-Hameed

Comments

@jschulist
Copy link

I pulled together some tests which reproduce the behavior I'm encountering. I've been testing using java build 1.8.0_101-b13, mssql-jdbc driver version 6.1.0.jre8 and Microsoft SQL Server 2016 (RTM) - 13.0.1601.5 (X64).

I suspect the issue might be caused by the driver code incorrectly assuming that the precision and scale values of BigDecimal mirror those of the decimal data type in SQL Server, namely the code found here.

Let me know if any additional details would be helpful.
@Suraiya-Hameed Suraiya-Hameed self-assigned this Dec 21, 2016
@Suraiya-Hameed
Copy link
Contributor

@jschulist Thanks for raising this issue and for the repro test code. We will submit a PR with the fix shortly.

@Suraiya-Hameed
Copy link
Contributor

PR#92 should fix precision issue. Please use it for testing.

@v-nisidh v-nisidh reopened this Jan 5, 2017
@v-nisidh v-nisidh closed this as completed Jan 6, 2017
@jschulist jschulist mentioned this issue Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Suraiya-Hameed Suraiya-Hameed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jschulist @Suraiya-Hameed @v-nisidh