Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local test failures. #179

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Fixed local test failures. #179

merged 1 commit into from
Mar 8, 2017

Conversation

v-nisidh
Copy link
Contributor

@v-nisidh v-nisidh commented Mar 8, 2017

Observed failures because of not handling propertly for database.
Observe similar problem with user. Added code for port / portnumber
parameter.

Observed failures because not handle condition propertly for database.
Observe similar problem with user. Added code for port / portnumber
parameter.
@codecov-io
Copy link

Codecov Report

Merging #179 into dev will decrease coverage by -0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #179      +/-   ##
============================================
- Coverage     29.88%   29.87%   -0.02%     
+ Complexity     1253     1251       -2     
============================================
  Files            97       97              
  Lines         23305    23305              
  Branches       3871     3871              
============================================
- Hits           6965     6962       -3     
- Misses        14962    14969       +7     
+ Partials       1378     1374       -4
Flag Coverage Δ Complexity Δ
#JDBC41 29.78% <ø> (+0.01%) 1248 <ø> (ø)
#JDBC42 29.78% <ø> (-0.06%) 1250 <ø> (-2)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 38.23% <0%> (-1.48%) 9% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 22.54% <0%> (-0.45%) 36% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 33.66% <0%> (-0.04%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.94% <0%> (+0.14%) 181% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8bec6...ca3955c. Read the comment docs.

@Suraiya-Hameed Suraiya-Hameed merged commit 68f58aa into microsoft:dev Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants