Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OSGI Headers in Manifest.MF #218

Merged
merged 6 commits into from
Apr 1, 2017
Merged

Added OSGI Headers in Manifest.MF #218

merged 6 commits into from
Apr 1, 2017

Conversation

v-nisidh
Copy link
Contributor

@v-nisidh v-nisidh commented Mar 23, 2017 •
edited
Loading

Added OSGI Headers in Manifest.MF For Issue #24

v-nisidh added 5 commits March 22, 2017 19:09
@v-nisidh
OSGIFied
28c9e0e 
Added OSGI headers.
@v-nisidh
OSGIfied
1b6c801 
Added for building jars for JDK 1.7 too
@v-nisidh
OSGIfied
041e1f5 
Fixed problem of having microsoft.sql in import & export packages.
@v-nisidh
OSGIfied
4e95f45 
Just keeping same convention.
@v-nisidh
Adding version details for maven-bundle-plugin
1e736e7 
Adding version details for maven-bundle-plugin
@v-nisidh v-nisidh mentioned this pull request Mar 23, 2017
Closed
@v-nisidh
Copy link
Contributor Author

Interestingly after putting version on org.apache.felix:maven-bundle-plugin travis is failing. Hoping for issue with travis-ci is temporary.

@v-nisidh v-nisidh closed this Mar 23, 2017
@v-nisidh v-nisidh reopened this Mar 23, 2017
@v-nisidh
Fixed Travis build issue.
46d52eb 
Somhow Travis CI could not able to resolve 3.3 maven-bundle from felix.
It works perfectly on local env & appveyor
@codecov-io
Copy link

codecov-io commented Mar 24, 2017 •
edited
Loading

Codecov Report

Merging #218 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #218      +/-   ##
============================================
- Coverage     32.87%   32.82%   -0.05%     
- Complexity     1437     1440       +3     
============================================
  Files            97       97              
  Lines         23385    23385              
  Branches       3889     3889              
============================================
- Hits           7688     7677      -11     
- Misses        14147    14165      +18     
+ Partials       1550     1543       -7
Flag Coverage Δ Complexity Δ
#JDBC41 32.73% <ø> (ø) 1432 <ø> (-1) ⬇️
#JDBC42 32.73% <ø> (-0.06%) 1435 <ø> (+3)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.23% <0%> (-0.52%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.94% <0%> (+0.14%) 183% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 39.7% <0%> (+1.47%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e66442...46d52eb. Read the comment docs.

@v-nisidh v-nisidh requested a review from xiangyushawn March 31, 2017 21:27
@v-nisidh v-nisidh merged commit 0ef9f3f into microsoft:dev Apr 1, 2017
@v-nisidh v-nisidh deleted the osgi branch April 12, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyushawn xiangyushawn xiangyushawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-nisidh @codecov-io @xiangyushawn