Tvp server cursor fix #234
Conversation
| } | ||
|
|
||
| private static void dropTables() throws SQLException { | ||
| stmt.executeUpdate("if object_id('" + srcTable + "','U') is not null" + " drop table " + srcTable); |
There was a problem hiding this comment.
Can we use Utils.dropTableIfExists to drop source & dest tables ?
| */ | ||
| @Test | ||
| public void testServerCursors() throws SQLException { | ||
| conn = DriverManager.getConnection(connectionString); |
There was a problem hiding this comment.
Can you add one test case for 3 result sets (2 TVPType and one Non-TVP) & 2 / 3 statements for these resultsets?
Codecov Report
@@ Coverage Diff @@
## dev #234 +/- ##
===========================================
+ Coverage 33.45% 34.4% +0.95%
- Complexity 1487 1551 +64
===========================================
Files 97 101 +4
Lines 23390 23656 +266
Branches 3840 3878 +38
===========================================
+ Hits 7824 8139 +315
+ Misses 14002 13917 -85
- Partials 1564 1600 +36
Continue to review full report at Codecov.
|
…sultSet.TYPE_FORWARD_ONLY and ResultSet.CONCUR_UPDATABLE
|
In ResultSet+storedProcedure+Cursor combination, no exception is thrown if there is no storedProcedure or if invalid/incompatible storedProcedure name is passed. |
|
@v-suhame fixed exception issue with invalid SP/TVP name |
|
|
||
| // reset command status which have been overwritten | ||
| if (tdsWritterCached) { | ||
| command.setRequestComplete(false); |
There was a problem hiding this comment.
Instead of resetting them to default, it will be safe to catch original value of these 3 variables and reset them. Also update these values in synchronized way just as in the existing code.
There was a problem hiding this comment.
Done, thank you for the findings
fixes #224