-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace for and while loops with foeach loops #421
Conversation
This increases the overall readability of the code, and has been supported since Java 5.
Codecov Report
@@ Coverage Diff @@
## dev #421 +/- ##
===========================================
+ Coverage 45.92% 46% +0.08%
- Complexity 2198 2203 +5
===========================================
Files 108 108
Lines 25210 25193 -17
Branches 4164 4164
===========================================
+ Hits 11577 11591 +14
+ Misses 11711 11677 -34
- Partials 1922 1925 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #421 +/- ##
===========================================
+ Coverage 45.92% 46% +0.08%
- Complexity 2198 2203 +5
===========================================
Files 108 108
Lines 25210 25193 -17
Branches 4164 4164
===========================================
+ Hits 11577 11591 +14
+ Misses 11711 11677 -34
- Partials 1922 1925 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ForEach loops are ideally more efficient way of performing iterations. I don't see any issues with these changes. We shall merge this PR soon.
@cheenamalhotra Thanks for the review. Is it possible to merge this now? |
Hi @JamieMagee, we'll merge your two PRs with the next preview release (v6.3.2). |
Testing was good, merging in. |
This increases the overall readability of the code, and has been supported since Java 5.