Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant String.toString() #501

Merged
merged 1 commit into from
Oct 7, 2017

Conversation

JamieMagee
Copy link
Member

Calling toString() on a String object is redundant

Calling toString() on a String object is redundant
@codecov-io
Copy link

Codecov Report

Merging #501 into dev will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #501      +/-   ##
============================================
- Coverage     46.64%   46.56%   -0.08%     
  Complexity     2218     2218              
============================================
  Files           108      108              
  Lines         25279    25279              
  Branches       4167     4167              
============================================
- Hits          11791    11772      -19     
- Misses        11463    11484      +21     
+ Partials       2025     2023       -2
Flag Coverage Δ Complexity Δ
#JDBC41 46.36% <50%> (-0.04%) 2209 <0> (+4)
#JDBC42 46.38% <50%> (-0.09%) 2208 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.58% <0%> (-0.7%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.32% <100%> (-0.39%) 238 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <50%> (ø) 277 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.15% <0%> (-1.29%) 63% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.43% <0%> (-1.09%) 88% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.32% <0%> (-0.25%) 165% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (+0.3%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.37% <0%> (+0.4%) 244% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dfd49...16bd589. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #501 into dev will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #501      +/-   ##
============================================
- Coverage     46.64%   46.56%   -0.08%     
  Complexity     2218     2218              
============================================
  Files           108      108              
  Lines         25279    25279              
  Branches       4167     4167              
============================================
- Hits          11791    11772      -19     
- Misses        11463    11484      +21     
+ Partials       2025     2023       -2
Flag Coverage Δ Complexity Δ
#JDBC41 46.36% <50%> (-0.04%) 2209 <0> (+4)
#JDBC42 46.38% <50%> (-0.09%) 2208 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.58% <0%> (-0.7%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.32% <100%> (-0.39%) 238 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <50%> (ø) 277 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.15% <0%> (-1.29%) 63% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.43% <0%> (-1.09%) 88% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.32% <0%> (-0.25%) 165% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (+0.3%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.37% <0%> (+0.4%) 244% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dfd49...16bd589. Read the comment docs.

@AfsanehR-zz AfsanehR-zz merged commit e5f7c6c into microsoft:dev Oct 7, 2017
@AfsanehR-zz
Copy link
Contributor

Thank you @JamieMagee for your effort in creating this pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants