Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database name as part of the key for handle cache #561

Merged
merged 2 commits into from
Nov 29, 2017

Conversation

xiangyushawn
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #561 into dev will increase coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #561      +/-   ##
============================================
+ Coverage     46.45%   46.48%   +0.02%     
- Complexity     2211     2214       +3     
============================================
  Files           108      108              
  Lines         25321    25332      +11     
  Branches       4175     4176       +1     
============================================
+ Hits          11764    11776      +12     
+ Misses        11538    11534       -4     
- Partials       2019     2022       +3
Flag Coverage Δ Complexity Δ
#JDBC41 46.33% <87.5%> (+0.13%) 2205 <1> (+5) ⬆️
#JDBC42 46.41% <87.5%> (+0.04%) 2210 <1> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 35.73% <100%> (+0.14%) 55 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.77% <100%> (+0.02%) 278 <1> (+1) ⬆️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.4% <83.33%> (+0.15%) 159 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-3.38%) 14% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.34% <0%> (-0.91%) 104% <0%> (+1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.51% <0%> (-0.26%) 240% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.39% <0%> (-0.22%) 44% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.86% <0%> (+0.08%) 241% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.43% <0%> (+0.09%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a940fbc...a9b6a7c. Read the comment docs.

@xiangyushawn xiangyushawn merged commit ba22e94 into microsoft:dev Nov 29, 2017
@xiangyushawn xiangyushawn deleted the v-xiangs-handle-DBName branch November 29, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants