-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry logic
To help debug an irreproducable/random mismatch error if it occurs in the future.
Affects getImportedKeys, getExportedKeys, and getCrossReference. Uses a single callable statement to create a temporary variable and edits UPDATE_RULE/DELETE_RULE before returning. Also changes the names of some of the columns to conform to JDBC specs.
rene-ye
changed the title
Fix for #665 - Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys
Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys
Apr 12, 2018
Codecov Report
@@ Coverage Diff @@
## dev #677 +/- ##
============================================
- Coverage 48.22% 48.07% -0.16%
+ Complexity 2583 2579 -4
============================================
Files 113 113
Lines 26626 26572 -54
Branches 4449 4450 +1
============================================
- Hits 12840 12774 -66
- Misses 11644 11658 +14
+ Partials 2142 2140 -2
Continue to review full report at Codecov.
|
peterbae
approved these changes
May 2, 2018
cheenamalhotra
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #665. Affects getImportedKeys, getExportedKeys, and getCrossReference. Uses a single callable statement to create a temporary variable and edits UPDATE_RULE/DELETE_RULE before returning. Also changes some column names to conform to JDBC specs. Tests appear to be flawed. Changed temporarily and will revisit in the future.