Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ms Jdbc driver more spring friendly - dev #9

Merged
merged 6 commits into from
Nov 25, 2016

Conversation

gstojsic
Copy link
Contributor

This is in relation to issue: https://connect.microsoft.com/SQLServer/Feedback/Details/3100563
It would greatly simplify Tvp usage in the Spring environment.
Per you request the pull request is made from the dev branch.

@YoungGah YoungGah added Under Review Used for pull requests under review under testing labels Nov 22, 2016
Copy link

@YoungGah YoungGah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing change

@AfsanehR-zz
Copy link
Contributor

AfsanehR-zz commented Nov 24, 2016

Thank you for your contribution!
According to the sample you provided in this link, you need to add setSqlType method to pass the TVP name.
inputDataTable.setSqlType("[dbo].[MsDriverSqlType]");
Could you make changes to the method names to be more informative?

@gstojsic
Copy link
Contributor Author

@v-afrafi If I understood correctly you want me to rename the sqlType property I added to SQLServerDataTable. In the setStructured api from SQLServerPreparedStatement the parameter is named tvpName. Would that name be ok?

@AfsanehR-zz
Copy link
Contributor

sounds good, thanks!

@gstojsic
Copy link
Contributor Author

Renamed sqlType to tvpName as requested.

@AfsanehR-zz AfsanehR-zz merged commit ef653c5 into microsoft:dev Nov 25, 2016
@AfsanehR-zz AfsanehR-zz removed the Under Review Used for pull requests under review label Nov 25, 2016
rene-ye added a commit that referenced this pull request Jan 31, 2018
lilgreenbird pushed a commit to lilgreenbird/mssql-jdbc that referenced this pull request Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants