TestTimeout in RunSettings #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaranigarg
approved these changes
Apr 17, 2018
| string runSettingxml = | ||
| @"<RunSettings> | ||
| <MSTestV2> | ||
| <TestTimeout>4000</TestTimeout> |
There was a problem hiding this comment.
Should also add one negative test case where timeout is invalid(negative value or non-integer value)
| @@ -645,6 +646,10 @@ private int GetTestTimeout(MethodInfo methodInfo, TestMethod testMethod) | |||
|
|
|||
| return timeoutAttribute.Timeout; | |||
| } | |||
| else if (globalTimeout > 0) | |||
There was a problem hiding this comment.
Have we asked @pvlakshm about precedence order?
There was a problem hiding this comment.
What happens when we passing runsettings arguments through commandline??
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making test timeout configurable via runsettings
microsoft/testfx-docs#40