Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Remove the use-isnan rule #372

Closed
ChrisMBarr opened this issue May 11, 2017 · 2 comments
Closed

Remove the use-isnan rule #372

ChrisMBarr opened this issue May 11, 2017 · 2 comments
Milestone

Comments

@ChrisMBarr
Copy link
Contributor

The use-isnan rule in this project has been marked as depricated since version 2.0.3 on April 21 of 2016 - more than 1 year ago at this point.

The rule in the base TSLint rules uses the same rule name, and the documentation states "Core rules cannot be overwritten with a custom implementation." which means that if someone configured "use-isnan": true then it would use the base rule and not this custom rule anyway, so it should be safe to remove.

@HamletDRC HamletDRC added this to the 5.0.1 milestone May 12, 2017
@HamletDRC
Copy link
Member

Thanks for staying on top of this for us!

@ChrisMBarr
Copy link
Contributor Author

Haha, no problem. I maintain a set of custom linting rule + some 3rd party ones (like these!) internally at my organization, and I have some unit tests to ensure that I include all the correct rules when I distribute them to our various apps. This is one rule I've always had to manually whitelist/exclude from my tests since it's a duplicate of the base rule.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants