Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

fix FP for no-string-based-set-timeout #402

Closed
wants to merge 1 commit into from
Closed

fix FP for no-string-based-set-timeout #402

wants to merge 1 commit into from

Conversation

tsmolka
Copy link
Contributor

@tsmolka tsmolka commented Nov 16, 2017

I found this false positive when running no-string-based-set-timeout over my code base. Proposed patch fixed it in my case.

@msftclas
Copy link

msftclas commented Nov 16, 2017 •
edited
Loading

CLA assistant check
All CLA requirements met.

@HamletDRC
Copy link
Member

Nice, thanks!

@HamletDRC HamletDRC added this to the 5.0.2 milestone Dec 18, 2017
@HamletDRC HamletDRC self-assigned this Dec 18, 2017
@HamletDRC HamletDRC closed this in 590653f Dec 18, 2017
@lijunle
Copy link
Member

lijunle commented Jan 2, 2018

Hi, @HamletDRC What is the plan to release version 5.0.2? We are enabling no-string-based-set-timeout but see this false-positive.

@lijunle lijunle mentioned this pull request Jan 2, 2018
Closed
@HamletDRC
Copy link
Member

doing it now :)

@lijunle
Copy link
Member

lijunle commented Jan 14, 2018

Just saw it! Thank you!

default

@tsmolka
Copy link
Contributor Author

tsmolka commented Jan 15, 2018

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@HamletDRC HamletDRC

Labels
None yet
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@tsmolka @msftclas @HamletDRC @lijunle