Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Update w3 reference in the react-a11y-role rule #844

Closed
arthurdenner opened this issue Mar 13, 2019 · 1 comment · Fixed by #847
Closed

Update w3 reference in the react-a11y-role rule #844

arthurdenner opened this issue Mar 13, 2019 · 1 comment · Fixed by #847
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Documentation Rules or repository tasks related to how to document code. Status: Accepting PRs Type: Bug
Milestone
6.2.0-beta

Comments

@arthurdenner
Copy link
Contributor

Currently, the react-a11y-role rule points to an old URL that doesn't exist anymore.

I never saw the previous URL, but I believe the content was the same contained in this URL.

However, we also have this new URL that seems to contain a more complete explanation about each one of the possible role values.

Should we update the URL in the react-a11y-role rule? If so, to which URL?

I'd be glad to open a PR with this change, if possible.
@arthurdenner arthurdenner changed the title Update w3 reference in react-a11y-role Update w3 reference in the react-a11y-role rule Mar 13, 2019
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Documentation Rules or repository tasks related to how to document code. labels Mar 13, 2019
@JoshuaKGoldberg
Copy link

Good catch! Let's go with the apparent new URL, https://www.w3.org/TR/wai-aria-1.1/#role_definitions.

@arthurdenner arthurdenner mentioned this issue Mar 13, 2019
Merged
4 tasks
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.1.1-beta milestone Apr 15, 2019
@IllusionMH IllusionMH modified the milestones: 6.1.1-beta, 6.2.0-beta May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Documentation Rules or repository tasks related to how to document code. Status: Accepting PRs Type: Bug
Projects
None yet
Milestone
6.2.0-beta
Development

Successfully merging a pull request may close this issue.

Update w3 reference in the react-a11y-role rule arthurdenner/tslint-microsoft-contrib
3 participants
@IllusionMH @JoshuaKGoldberg @arthurdenner