This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Disable the use of console.error
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have noticed that this project already locally disables this rule (as if it were present in the config) at https://github.com/astorije/tslint-microsoft-contrib/blame/master/src/functionNameRule.ts#L101-L103 and https://github.com/astorije/tslint-microsoft-contrib/blame/master/src/reactUnusedPropsAndStateRule.ts#L71-L73. We realized `console.error` was not forbidden in the recommended configuration and think it would be a sane thing to enforce by default. I reckon this will be a breaking change however.
|
Hey there, any chance someone could take a look at this PR (and other open PRs)? 🙂 |
|
Hey @astorije, sorry about the delay! Agreed that this should be the case (and that it's a breaking change). Should be noted in the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that this project already locally disables this rule (as if it were present in the config) here and here (the only 2 uses of
console.errorin this repo).We realized
console.errorwas not forbidden in the recommended configuration and think it would be a sane thing to enforce by default. I reckon this will be a breaking change however.